-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: lambda@edge
submodule
#204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bridgecrew has found infrastructure configuration errors in this PR ⬇️
…-aws-cloudfront-s3-cdn into feat/lambda-at-edge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change details
-
Error ID Change Path Resource BC_AWS_SERVERLESS_4 Fixed /modules/lambda@edge/main.tf aws_lambda_function.default BC_AWS_GENERAL_63 Fixed /modules/lambda@edge/main.tf aws_lambda_function.default BC_AWS_GENERAL_64 Fixed /modules/lambda@edge/main.tf aws_lambda_function.default BC_AWS_GENERAL_65 Fixed /modules/lambda@edge/main.tf aws_lambda_function.default
/test all |
…-aws-cloudfront-s3-cdn into feat/lambda-at-edge
/test all |
…-aws-cloudfront-s3-cdn into feat/lambda-at-edge
… regarding us-east-1 provider.
/test all |
…ction destruction; fix versions.tf for submodule and examples/complete.
…-aws-cloudfront-s3-cdn into feat/lambda-at-edge
/test all |
/test all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a few nitpicks
Co-authored-by: Andriy Knysh <[email protected]>
/test all |
what
versions.tf
inexamples/complete
according to TFLintwhy
references
notes
Please note that a side effect of this change is that the test suite will now take ~30 minutes to run.