Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main.tf] Updated conditions with included cache_policy_id variable #210

Merged
merged 5 commits into from
Jan 27, 2022

Conversation

eboboshka
Copy link
Contributor

what

  • Fixed conditions when using cache_policy_id

why

  • When using cache_policy_id, the module tries to change ttl values from zero to the default values.
      ~ default_cache_behavior {
          ~ default_ttl            = 0 -> 60
          ~ max_ttl                = 0 -> 31536000
            # (10 unchanged attributes hidden)

            # (1 unchanged block hidden)
        }
  • There is no need to use the mandatory ARN lambda in Cusom Behavior.

references

@eboboshka eboboshka requested review from a team as code owners January 21, 2022 20:09
@eboboshka eboboshka requested review from Gowiem and milldr and removed request for a team January 21, 2022 20:09
@mergify
Copy link

mergify bot commented Jan 27, 2022

This pull request is now in conflict. Could you fix it @eboboshka? 🙏

@korenyoni korenyoni added bug 🐛 An issue with the system no-release Do not create a new release (wait for additional code changes) labels Jan 27, 2022
@korenyoni
Copy link
Member

/test all

Copy link
Member

@korenyoni korenyoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An issue with the system no-release Do not create a new release (wait for additional code changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants