Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme/example fix #229

Merged
merged 5 commits into from
Aug 10, 2023
Merged

Conversation

samcrudge
Copy link
Contributor

what

  • Describe high-level what changed as a result of these commits (i.e. in plain-english, what do these changes mean?)
  • Example of 'Origin Group with the origin created by this module as a primary origin and an additional
    S3 bucket as a failover origin' showed the s3_origins & origin_group as a map(any) rather than a list(map) causing builds to fail when using said example.

why

  • Provide the justifications for the changes (e.g. business case).
  • Describe why these changes were made (e.g. why do these commits fix the problem?)
  • Examples that reflect the required schema.

references

  • Link to any supporting github issues or helpful documentation to add some context (e.g. stackoverflow).
  • README.md & README.yaml

@samcrudge samcrudge requested review from a team as code owners April 7, 2022 19:56
@samcrudge samcrudge requested review from Makeshift and RothAndrew and removed request for a team April 7, 2022 19:56
@joe-niland
Copy link
Member

@samcrudge apologies that this was missed - did you want to merge in the main branch so we can get this one merged?

@samcrudge
Copy link
Contributor Author

Il do that today

@samcrudge
Copy link
Contributor Author

@joe-niland I've synced the branches. do you need me to run any commands?

@joe-niland
Copy link
Member

/terratest

@joe-niland joe-niland requested review from joe-niland and removed request for Makeshift and RothAndrew August 10, 2023 20:28
@joe-niland joe-niland added the patch A minor, backward compatible change label Aug 10, 2023
@joe-niland joe-niland merged commit 91ab131 into cloudposse:main Aug 10, 2023
@joe-niland
Copy link
Member

Thanks for your contribution @samcrudge !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch A minor, backward compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants