Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade cloudposse/s3-log-storage/aws to 1.0.0 #251

Conversation

paulvandenburg
Copy link

@paulvandenburg paulvandenburg commented Dec 8, 2022

This PR contains the following updates:

cloudposse/s3-log-storage/aws (source) module major 0.26.0 -> 1.0.0

Supersedes #250

Should fix failing CI.

@paulvandenburg paulvandenburg requested review from a team as code owners December 8, 2022 15:46
@paulvandenburg paulvandenburg requested review from jamengual and woz5999 and removed request for a team December 8, 2022 15:46
@paulvandenburg paulvandenburg force-pushed the upgrade-s3-log-storage-to-v1 branch from 8c3ca46 to f616ba6 Compare December 8, 2022 16:29
@paulvandenburg paulvandenburg force-pushed the upgrade-s3-log-storage-to-v1 branch from 56cbca5 to 270a33f Compare December 8, 2022 16:48
@paulvandenburg
Copy link
Author

After testing I think this is complete.

For the release notes perhaps recommend the various imports you might want to do so it won't try to create the likely already existing config. Since the split out s3 resources causes this.

Importing is as simple as mentioning the various new s3 resources with the related bucket name:

  • aws_s3_bucket_acl
  • aws_s3_bucket_server_side_encryption_configuration
  • aws_s3_bucket_versioning
  • aws_s3_bucket_logging
  • aws_s3_bucket_website_configuration
  • aws_s3_bucket_cors_configuration
  • aws_s3_bucket_lifecycle_configuration

Trial and error might be easiest here since various setups trigger various sets of those appearing in your terraform plan.
As it could come from all of this modules main.tf, the nested logs module or the logs module's nested s3-bucket module.

@hans-d hans-d closed this Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants