Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix website_enabled #253

Merged
merged 2 commits into from
Dec 20, 2022
Merged

bugfix website_enabled #253

merged 2 commits into from
Dec 20, 2022

Conversation

Benbentwo
Copy link
Member

what

  • website enabled means we should use
    • Public Bucket
    • No TLS Verify on bucket assets (not used by cloudfront in website mode)
    • No Lambda Edge association

why

  • Bugfix Website Mode

references

@Benbentwo Benbentwo requested review from a team as code owners December 20, 2022 21:07
@Benbentwo Benbentwo requested review from dotCipher and RothAndrew and removed request for a team December 20, 2022 21:07
@Benbentwo
Copy link
Member Author

/test all

@Benbentwo Benbentwo added the patch A minor, backward compatible change label Dec 20, 2022
@Benbentwo Benbentwo merged commit b44d7b3 into master Dec 20, 2022
@Benbentwo Benbentwo deleted the bugfix/websitemode branch December 20, 2022 23:53
@Benbentwo Benbentwo mentioned this pull request Dec 21, 2022
Merged
Benbentwo added a commit that referenced this pull request Dec 21, 2022
@Benbentwo
Revert #253 (#254)
7f2b318 
* lambda function association based on vars (reverts part of previous pr)

* lambda function association based on vars (reverts part of previous pr)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@dotCipher dotCipher Awaiting requested review from dotCipher dotCipher was automatically assigned from cloudposse/contributors

@RothAndrew RothAndrew Awaiting requested review from RothAndrew RothAndrew was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Benbentwo @aknysh @cloudpossebot