Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed deprecated aws_s3_bucket attributes #293

Merged
merged 4 commits into from
Mar 4, 2024
Merged

Conversation

andruccho
Copy link
Contributor

The following options were deprecated, and have either been updated, or replaced with the new necessary resources:

  • server_side_encryption_configuration replaced with aws_s3_bucket_server_side_encryption_configuration resource
  • versioning replaced with aws_s3_bucket_versioning resource
  • cors_rule replaced with aws_s3_bucket_cors_configuration resource
  • acl replaced with aws_s3_bucket_acl resource
  • bucket_versioning input added

Pull request is almost the same with #266, exclude override_json replaced with override_policy_documents option, because for me it breaks logs submodule behavior.
I'm getting no deprecation warnings without this change (my aws provider version is 5.30.0).

@andruccho andruccho requested review from a team as code owners December 13, 2023 08:23
@ChrisBoik
Copy link

Came to do the same, thanks 👍

@hans-d
Copy link

hans-d commented Mar 2, 2024

/terratest

@hans-d hans-d added wip Work in Progress: Not ready for final review or merge and removed wip Work in Progress: Not ready for final review or merge labels Mar 2, 2024
@hans-d
Copy link

hans-d commented Mar 3, 2024

/terratest

@hans-d hans-d enabled auto-merge (squash) March 3, 2024 21:34
@hans-d
Copy link

hans-d commented Mar 4, 2024

/terratest

@hans-d hans-d added wip Work in Progress: Not ready for final review or merge and removed wip Work in Progress: Not ready for final review or merge labels Mar 4, 2024
@hans-d hans-d self-assigned this Mar 4, 2024
@hans-d hans-d merged commit d208a62 into cloudposse:main Mar 4, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants