Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for realtime log config to ordered_cache #295

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

mschfh
Copy link
Contributor

@mschfh mschfh commented Mar 7, 2024

what

This PR adds realtime log config support for additional cache behaviours (Similar to #162 which added default cache behaviour)

references

#162 - Added realtime_log_config_arn for default cache behaviour

@mschfh mschfh requested review from a team as code owners March 7, 2024 07:46
@mschfh mschfh requested review from Gowiem and joe-niland March 7, 2024 07:46
Copy link

mergify bot commented Mar 9, 2024

Thanks @mschfh for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

@mergify mergify bot added the triage Needs triage label Mar 9, 2024
Benbentwo
Benbentwo previously approved these changes Mar 25, 2024
@Benbentwo
Copy link
Member

/terratest

@mergify mergify bot added triage Needs triage and removed triage Needs triage labels Mar 25, 2024
@mergify mergify bot added triage Needs triage and removed triage Needs triage labels Mar 25, 2024
@mergify mergify bot added triage Needs triage and removed triage Needs triage labels Mar 25, 2024
@Nuru
Copy link
Contributor

Nuru commented Mar 26, 2024

Sorry, @mschfh , it looks like the README needs to be rebuilt. Please run

make init
make readme

and push the updated *.md files.

@mschfh mschfh force-pushed the ordered-cache-realtime-logging branch from 3f7913c to d2def3f Compare March 26, 2024 15:54
@mschfh
Copy link
Contributor Author

mschfh commented Mar 26, 2024

@Nuru updated the docs and rebased on main

@mergify mergify bot added the triage Needs triage label Mar 26, 2024
@Benbentwo
Copy link
Member

/terratest

@Benbentwo Benbentwo enabled auto-merge (squash) March 26, 2024 16:59
@Benbentwo Benbentwo merged commit a8aa18d into cloudposse:main Mar 26, 2024
21 checks passed
@mergify mergify bot removed the triage Needs triage label Mar 26, 2024
@mschfh mschfh deleted the ordered-cache-realtime-logging branch March 26, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants