Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for origin-access-control #319

Merged
merged 9 commits into from
Oct 2, 2024
Merged

Conversation

rankin-tr
Copy link
Contributor

@rankin-tr rankin-tr commented Aug 19, 2024

what

  • add Origin Access Control feature
    • add var.origin_access_type to enable Origin Access Identity or Origina Access Control policy
    • add aws_cloudfront_origin_access_control.default resource
    • add origin_access_control_id argument to origin config on aws_cloudfront_distribution.default
  • update example code
  • update README

why

  • provide the ability to make use of an Origin Access Control
    • retain default origin access identity behavior
  • AWS recommends using origin access control
  • Origin Access Identities are flagged in AWS Security Hub

references

@rankin-tr rankin-tr requested review from a team as code owners August 19, 2024 18:17
@rankin-tr rankin-tr requested review from Gowiem and jamengual August 19, 2024 18:17
@mergify mergify bot added the triage Needs triage label Aug 19, 2024
@philchristensen
Copy link

Just adding a positive review; I tried this branch myself in a project and it worked great. Thanks @rankin-tr !

main.tf Show resolved Hide resolved
@dudymas
Copy link
Contributor

dudymas commented Aug 29, 2024

/terratest

@dudymas
Copy link
Contributor

dudymas commented Sep 2, 2024

/terratest

1 similar comment
@dudymas
Copy link
Contributor

dudymas commented Sep 5, 2024

/terratest

@dudymas
Copy link
Contributor

dudymas commented Sep 6, 2024

/terratest

@dudymas
Copy link
Contributor

dudymas commented Sep 6, 2024

/terratest

dudymas
dudymas previously approved these changes Sep 6, 2024
@dudymas
Copy link
Contributor

dudymas commented Sep 6, 2024

/terratest

@mergify mergify bot removed the triage Needs triage label Sep 6, 2024
@Nuru
Copy link
Contributor

Nuru commented Sep 7, 2024

/terratest

2 similar comments
@goruha
Copy link
Member

goruha commented Sep 7, 2024

/terratest

@dudymas
Copy link
Contributor

dudymas commented Sep 11, 2024

/terratest

Copy link

mergify bot commented Sep 19, 2024

💥 This pull request now has conflicts. Could you fix it @rankin-tr? 🙏

@mergify mergify bot added the conflict This PR has conflicts label Sep 19, 2024
@mergify mergify bot closed this Sep 19, 2024
Copy link

mergify bot commented Sep 19, 2024

This PR was closed due to inactivity and merge conflicts. 😭
Please resolve the conflicts and reopen if necessary.

@mergify mergify bot removed the conflict This PR has conflicts label Sep 19, 2024
@dudymas dudymas reopened this Sep 26, 2024
@mergify mergify bot added the triage Needs triage label Sep 26, 2024
@GabisCampana
Copy link

@Nuru @dudymas

@dudymas
Copy link
Contributor

dudymas commented Sep 26, 2024

/terratest

@mergify mergify bot removed the triage Needs triage label Sep 26, 2024
Copy link
Member

@Benbentwo Benbentwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@Benbentwo Benbentwo merged commit c44dbde into cloudposse:main Oct 2, 2024
49 checks passed
Copy link
Contributor

github-actions bot commented Oct 2, 2024

These changes were released in v0.95.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for origin-access-control to replace origin-access-identity
8 participants