Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IPv6 variables. Change AWS region for tests. Fix enabled logic. Update LICENSE #68

Merged
merged 1 commit into from
Jan 16, 2020

Conversation

aknysh
Copy link
Member

@aknysh aknysh commented Jan 16, 2020

what

  • Fix IPv6 variables
  • Change AWS region for tests
  • Fix enabled logic
  • Use terraform-null-label instead of terraform-terraform-label
  • Update LICENSE

why

  • Duplicate ipv6_enabled variables - we need only one flag
  • We use us-east-2 region for Terratest now (us-west-1 is very limited region)
  • enabled logic for module "dns" was wrong
  • terraform-null-label has more features and works without issues in TF 0.12

related

@aknysh aknysh requested a review from osterman January 16, 2020 03:42
@aknysh aknysh self-assigned this Jan 16, 2020
@aknysh aknysh merged commit 2dbe0c8 into master Jan 16, 2020
@aknysh aknysh deleted the fix-ipv6-variables branch January 16, 2020 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support IPv6
2 participants