Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding versioning to S3 origin bucket #91

Merged
merged 7 commits into from
Aug 31, 2020
Merged

Adding versioning to S3 origin bucket #91

merged 7 commits into from
Aug 31, 2020

Conversation

hawkesn
Copy link
Contributor

@hawkesn hawkesn commented Jul 23, 2020

what

  • This change allows you to turn on versioning for objects in the bucket

why

  • For building static websites, we require the use of s3+cdn that this module provides. However, in some instances, we would like to ability to roll back to a previous version.
  • Since this is meant for a "dev" like environment, we set the cdn ttl to very low to pull objects back from the s3 bucket.
  • The reason we use the CDN is to support TLS since s3 does not.

references

  • N/A

@hawkesn hawkesn requested a review from a team as a code owner July 23, 2020 22:24
@hawkesn hawkesn requested review from jhosteny and nitrocode and removed request for a team July 23, 2020 22:24
nitrocode
nitrocode reviewed Jul 28, 2020
View reviewed changes
main.tf Outdated Show resolved Hide resolved
nitrocode
nitrocode reviewed Jul 28, 2020
View reviewed changes
main.tf Outdated Show resolved Hide resolved
@nitrocode
Copy link
Member

/rebuild-readme

@nitrocode
Copy link
Member

/terraform-fmt

@nitrocode
Copy link
Member

/test all

@hawkesn @nitrocode
Apply suggestions from code review
333b21b 
Adding suggestions from @nitrocode

Co-authored-by: nitro <[email protected]>
@hawkesn
Copy link
Contributor Author

hawkesn commented Jul 29, 2020

Added those changes in. Thanks @nitrocode for the review! 👍

@osterman
Copy link
Member

/test all

@nitrocode
Copy link
Member

/rebuild-readme

@nitrocode
Copy link
Member

/test all

@hawkesn
Copy link
Contributor Author

hawkesn commented Aug 31, 2020

Is this good to merge?

@Gowiem Gowiem merged commit 417eb7b into cloudposse:master Aug 31, 2020
@hawkesn
Copy link
Contributor Author

hawkesn commented Aug 31, 2020

Sweet! Thanks 👍

@Gowiem
Copy link
Member

Gowiem commented Aug 31, 2020

@hawkesnc Thanks for the contribution! Released as 0.34.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode left review comments

@Gowiem Gowiem Gowiem approved these changes

@jhosteny jhosteny Awaiting requested review from jhosteny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hawkesn @nitrocode @osterman @Gowiem @actions-bot