Skip to content

v0.55.0
Compare
Choose a tag to compare
@cloudpossebot cloudpossebot released this 31 Mar 03:04
0.55.0
06f359a
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Learn about vigilant mode.
Remove static bucket hack @nitrocode (#143)

This is for comments to ensure this PR doesn't break backwards compatibility.

what

  • This simplifies calculating the correct bucket regional domain name using the s3 bucket's bucket_regional_domain_name instead of the original hack from PR #17
  • I saw this output used on the official hashicorp docs for the aws_cloudfront_distribution resource

why

  • This simplifies the regional domain name
  • Prevents having to maintain a list of buckets with dashes
  • Prevents issues related to the data source of the aws-cli s3 bucket
  • Should maintain destruction of the resources as it does before

references

  • More digging down the rabbit hole in this ticket #101
Assets 2
Loading