Skip to content

v0.61.0 Breaking change
Compare
Choose a tag to compare
@cloudpossebot cloudpossebot released this 26 Apr 23:26
0.61.0
d378e4b
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Learn about vigilant mode.

Breaking change:

  • If you had set website_enabled = true prior to this release, this module would create a publicly accessible S3 website. This release introduces a change to attempt to block that public access (see README for details). If you wanted the S3 website site to be publicly available (bypassing Cloudfront), this release will break it.

Breaking back:

  • Release v0.64.0 preserves the feature, but makes it optional with the variable s3_website_password_enabled and by setting that to default to false, restores the previous default.
Make S3 website private; add S3 origin @jmcgeheeiv (#105)

What

In this PR I added these enhancements:

  • Make the S3 website accessible only via CloudFront. You may prefer that I add a variable to make this optional. Let me know.
  • Add S3 origins, which are different from the currently-supported custom origins
  • Change http_port and https_port to numbers merely to dissuade observers from attempting to use null. null causes a very, very hard-to-diagnose error that does not reveal the line number.

I will further note that Terraform insists that the complete data structure appearing in variables.tf be specified for custom_origin and s3_origin variables. Thus lookup() with default values is immaterial.

Why

The reasons are included in the list of enhancements above. I hope it is more readable that way.

Assets 2
Loading