Implement Cloud Trails #1
Conversation
main.tf
Outdated
| @@ -0,0 +1,51 @@ | |||
| module "tf_label" { | |||
| source = "../tf_label" | |||
main.tf
Outdated
| name = "${var.name}" | ||
| } | ||
|
|
||
| resource "aws_cloudtrail" "ct" { |
main.tf
Outdated
| include_global_service_events = "${var.include_global_service_events}" | ||
| } | ||
|
|
||
| resource "aws_s3_bucket" "cloud_trail" { |
There was a problem hiding this comment.
Let's just call it default since there is only one bucket used.
variables.tf
Outdated
| } | ||
|
|
||
| variable "name" { | ||
| default = "" |
There was a problem hiding this comment.
Default the name to cloudtrails
README.md
Outdated
| ## Usage | ||
| ``` | ||
| module "ct" { |
There was a problem hiding this comment.
call it cloudtrails. normalize the spacing the way that terraform fmt does it.
README.md
Outdated
| ``` | ||
| module "ct" { | ||
| source = "github.com/cloudposse/tf_cloudtrail" |
There was a problem hiding this comment.
prefer you use explicit notation.
e.g.
source = "git::https://github.com/cloudposse/tf_label.git?ref=master"
README.md
Outdated
| #### Optional | ||
|
|
||
| * enable_logging: Enable logging, set to 'false' to Pause logging (default = true) |
There was a problem hiding this comment.
Use markdown formatting for code.
E.g. enable_logging
@comeanother please help format explanation.
|
README.md
Outdated
| #### Optional | ||
|
|
||
| * `enable_logging`: Enable logging, set to 'false' to Pause logging (default = true) |
There was a problem hiding this comment.
false is also a keyword, so it should be markdown too. Same with default = true
README.md
Outdated
|
|
||
| #### Optional | ||
|
|
There was a problem hiding this comment.
Please "borrow" the same language used on the terraform docs. See: https://www.terraform.io/docs/providers/aws/r/cloudtrail.html
main.tf
Outdated
| bucket = "${module.tf_label.id}" | ||
| force_destroy = false | ||
|
|
||
| policy = <<POLICY |
There was a problem hiding this comment.
Don't use HEREDOC when a better resource type exists. https://www.terraform.io/docs/providers/aws/d/iam_policy_document.html
main.tf
Outdated
| include_global_service_events = "${var.include_global_service_events}" | ||
| } | ||
|
|
||
| data "aws_iam_policy_document" "cloudtrail" { |
There was a problem hiding this comment.
call it default since there's only one.
main.tf
Outdated
| @@ -0,0 +1,67 @@ | |||
| module "tf_label" { | |||
| source = "git::https://github.com/cloudposse/tf_label.git?ref=master" | |||
outputs.tf
Outdated
| @@ -0,0 +1,3 @@ | |||
| output "s3_trail_bucket_name" { | |||
There was a problem hiding this comment.
Let's just call it bucket_name since there is no intention to have more than one bucket.
README.md
Outdated
| Setup and manage CloudTrail | ||
|
|
||
| ### Argument Reference |
There was a problem hiding this comment.
Use second-level headers
## instead of ###
What
Why