Changed event selector to a list, so that it can be supplied as a list with a map

[Jamie-BitFlight]

what

• Change the event_selector var from a map to a list type.

why

It is currently a type map, that then gets put inside a list.
Even though it is a null map by default, because it is embedded into a list, it is evaluated by the cloudtrail resource.

And because it gets evaluated by the resource it triggers this bug:
hashicorp/terraform-provider-aws#5448

By switching it to a list, it means that by default instead of being a null map in a null list, it is just a null list. Which is skipped over, and doesn't trigger the bug.

TF Apply with the Cloudtrail module always comes up with :

~ module.cloudtrail.aws_cloudtrail.default
     event_selector.#:                           "0" => "1"
     event_selector.0.include_management_events: "" => "true"
     event_selector.0.read_write_type:           "" => "All"

[maartenvanderhoef]

Thanks @Jamie-BitFlight!

[aknysh]

@Jamie-BitFlight thanks!
Did you test it?
(I remember having some issues with those data types, but don't remember exactly what it was).

[Jamie-BitFlight]

Yeah, I tested it using the example. And @maartenvanderhoef tested it against his infra as well. He caught the bug, and I fixed it, he tested the branch.

[osterman]

Need to rebuild readme since the variable type and description changed