Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "enabled" flag to the module #22

Merged
merged 3 commits into from
May 29, 2019

Conversation

christopherriley
Copy link

WHAT

add enabled flag to the module

Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @christopherriley

Looks good, but please rebuild README by executing these commands:

make init
make readme/deps
make readme

It will add the new variables and outputs to README.md automatically.

In general, any changes to README should be made in README.yaml (not in this case), and after that executing the commands above will rebuild README.yaml into README.md and add all new variables and outputs to README.md

Also, since resource "aws_cloudtrail" "default" has count, it's already a list (not a single resource).
We use splat+join pattern everywhere to access resources with counts (otherwise TF could throw errors in some cases).

In outputs.tf, please update all outputs to use splat+ join:

For example,

output "cloudtrail_id" {
  value       = "${join("", aws_cloudtrail.default.*.id)}"
  description = "The name of the trail"
}

thanks

@aknysh aknysh self-requested a review May 29, 2019 20:09
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aknysh aknysh merged commit 396f80e into cloudposse:master May 29, 2019
@aknysh aknysh deleted the add-enabled-flag branch May 29, 2019 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants