Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CloudTrail Advanced Event Selector #70

Merged
merged 11 commits into from
Apr 15, 2024

Conversation

X-Guardian
Copy link
Contributor

@X-Guardian X-Guardian commented Apr 11, 2024

what

Add support for the CloudTrail advanced event selector

Also bumps the example cloudtrail_s3_bucket module and Terraform versions to fix test errors.

By @Nuru:

references

@X-Guardian X-Guardian requested review from a team as code owners April 11, 2024 13:38
@X-Guardian X-Guardian requested review from kevcube and Gowiem April 11, 2024 13:38
@mergify mergify bot added the triage Needs triage label Apr 11, 2024
jamengual
jamengual previously approved these changes Apr 11, 2024
Copy link

@jamengual jamengual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @X-Guardian for the contribution, once the terratest past we should be good to go

@jamengual
Copy link

/terratest

@mergify mergify bot removed the triage Needs triage label Apr 11, 2024
@mergify mergify bot added the triage Needs triage label Apr 11, 2024
@X-Guardian
Copy link
Contributor Author

Looks like the test framework is using a very old version of Terraform, so I have bumped the Terraform version in the example.

I have only added a single object...

@jamengual
Copy link

/terratest

@X-Guardian
Copy link
Contributor Author

The successful running of the tests is blocked by cloudposse/terraform-aws-cloudtrail-s3-bucket#90

@jamengual
Copy link

/terratest

@mergify mergify bot added the needs-cloudposse Needs Cloud Posse assistance label Apr 15, 2024
Copy link

mergify bot commented Apr 15, 2024

Important

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

@Nuru Nuru removed the needs-cloudposse Needs Cloud Posse assistance label Apr 15, 2024
@Nuru Nuru added minor New features that do not break anything and removed triage Needs triage labels Apr 15, 2024
@Nuru
Copy link
Contributor

Nuru commented Apr 15, 2024

/terratest

@mergify mergify bot added the needs-cloudposse Needs Cloud Posse assistance label Apr 15, 2024
@Nuru Nuru merged commit 7610c67 into cloudposse:main Apr 15, 2024
43 of 49 checks passed
@mergify mergify bot removed the needs-cloudposse Needs Cloud Posse assistance label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor New features that do not break anything
Projects
None yet
3 participants