Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure we can take v3 of the aws provider #62

Merged
merged 6 commits into from
Sep 3, 2020
Merged

ensure we can take v3 of the aws provider #62

merged 6 commits into from
Sep 3, 2020

Conversation

jurgenweber
Copy link
Contributor

what

do not restrict the aws provider version to just v2

why

cloudposse/terraform-aws-route53-cluster-hostname#23
the aws cloud provider has v13 fixes and requirements also

references

closes #61
#61

@jurgenweber jurgenweber requested a review from a team as a code owner August 26, 2020 04:44
versions.tf Outdated Show resolved Hide resolved
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @jurgenweber , please see comments

@jurgenweber
Copy link
Contributor Author

updated.

versions.tf Outdated Show resolved Hide resolved
versions.tf Outdated Show resolved Hide resolved
versions.tf Outdated Show resolved Hide resolved
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@jurgenweber jurgenweber requested a review from aknysh September 3, 2020 04:29
@aknysh
Copy link
Member

aknysh commented Sep 3, 2020

/rebuild-readme

@aknysh
Copy link
Member

aknysh commented Sep 3, 2020

/test all

Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@aknysh aknysh merged commit 1e58b92 into cloudposse:master Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants