Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove lifecycle ignore changes for ami argument #205

Merged
merged 1 commit into from
Aug 17, 2024
Merged

fix: remove lifecycle ignore changes for ami argument #205

merged 1 commit into from
Aug 17, 2024

Conversation

nitrocode
Copy link
Member

what

  • remove lifecycle ignore changes for ami argument

why

  • This change looks unintentional based on the PR description
  • We'd like to allow AMIs to recreate the EC2 for singletons that aren't production facing

references

@nitrocode
chore: revert pr #145
0e4e374 
This change looks unintentional based on the PR description
@nitrocode nitrocode requested review from a team as code owners August 17, 2024 22:04
@nitrocode nitrocode requested review from Gowiem and joe-niland August 17, 2024 22:04
@mergify mergify bot added the triage Needs triage label Aug 17, 2024
@mergify mergify bot removed the triage Needs triage label Aug 17, 2024
@nitrocode
Copy link
Member Author

/terratest

@nitrocode nitrocode enabled auto-merge (squash) August 17, 2024 22:52
@nitrocode nitrocode merged commit c4be480 into main Aug 17, 2024
38 checks passed
@nitrocode nitrocode deleted the rm-ami-ignore-changes branch August 17, 2024 23:01
@github-actions GitHub Actions
Copy link
Contributor

These changes were released in v1.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem is a code owner automatically assigned from cloudposse/contributors

@joe-niland joe-niland Awaiting requested review from joe-niland joe-niland is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nitrocode @osterman