Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add Thorough Automated Testing and Bump Minimum Terraform Version to 0.13.0 #139

Merged
merged 6 commits into from
Jun 11, 2021

Conversation

korenyoni
Copy link
Member

what

  • Ensure examples/complete is creating an aws_ecs_task_definition and test the task definition in the automated testing.
  • Fix examples/multiple_definitions
  • Bump minimum Terraform required version to 0.13.0
  • Add context.tf to examples/complete to ensure aws_ecs_task_definition has tags.

why

  • We should be ensuring that the entire container definition output of this module is accepted by aws_ecs_task_definition and produces an identical result to the resource container_definitions output.
  • Bumping to 0.13.0 as the minimum supported version ensures this module is easier to maintain down the road.

references

  • N/A

@korenyoni korenyoni requested review from a team as code owners June 11, 2021 14:44
@korenyoni korenyoni requested review from RothAndrew and SweetOps June 11, 2021 14:44
@korenyoni
Copy link
Member Author

/test all

@korenyoni
Copy link
Member Author

/test all

@korenyoni
Copy link
Member Author

/test all

@korenyoni korenyoni merged commit ec4c4a6 into master Jun 11, 2021
@korenyoni korenyoni deleted the fix/thorough-testing-and-tf-bump branch June 11, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants