Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Duplicate name in portMapping fixed & Docs Updated #171

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

Hackerbone
Copy link
Contributor

@Hackerbone Hackerbone commented Oct 10, 2023

what

The portMapping parameter had a duplicate name field occurrence

why

Failure in creating services in the new release v0.61.0

references

I was waiting for the previous PR to get merged since I use this module in my project for a while. Saw CI checks didn't pass so I made a new fix PR.

@Hackerbone Hackerbone requested review from a team as code owners October 10, 2023 12:22
nitrocode
nitrocode previously approved these changes Oct 25, 2023
@nitrocode nitrocode added the patch A minor, backward compatible change label Oct 25, 2023
@nitrocode nitrocode enabled auto-merge (squash) October 25, 2023 12:55
@nitrocode nitrocode disabled auto-merge October 25, 2023 12:58
@Hackerbone
Copy link
Contributor Author

Hey @nitrocode can you re-approve workflow? I ran the make init/readme commands

@nitrocode
Copy link
Member

/test terratest

@nitrocode
Copy link
Member

/test test/terratest

@Hackerbone
Copy link
Contributor Author

Hi @nitrocode, I think running only /terratest should work?

@nitrocode
Copy link
Member

/terratest

@nitrocode nitrocode enabled auto-merge (squash) October 26, 2023 18:12
@nitrocode nitrocode merged commit 1a38bc6 into cloudposse:main Oct 26, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch A minor, backward compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants