do not merge! demo purpose #98
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osterman
reviewed
Jan 26, 2021
README.md
Outdated
Comment on lines
422
to
426
| - [terraform-provider-aws](https://github.com/hashicorp/terraform-provider-aws) - terraform-provider-aws | ||
| - [terraform-provider-kubernetes](https://github.com/hashicorp/terraform-provider-kubernetes) - terraform-provider-kubernetes | ||
| - [terraform-provider-local](https://github.com/hashicorp/terraform-provider-local) - terraform-provider-local | ||
| - [terraform-provider-null](https://github.com/hashicorp/terraform-provider-null) - terraform-provider-null | ||
| - [terraform-provider-template](https://github.com/hashicorp/terraform-provider-template) - terraform-provider-template |
There was a problem hiding this comment.
@SweetOps Providers should go under references; ideally, we'd link to the terraform registry documentation for the provider instead.
osterman
reviewed
Jan 26, 2021
Comment on lines
+418
to
+421
| - [terraform-aws-eks-fargate-profile](https://github.com/cloudposse/terraform-aws-eks-fargate-profile) - Terraform module to provision an EKS Fargate Profile | ||
| - [terraform-aws-eks-node-group](https://github.com/cloudposse/terraform-aws-eks-node-group) - Terraform module to provision an EKS Node Group | ||
| - [terraform-aws-eks-iam-role](https://github.com/cloudposse/terraform-aws-eks-iam-role) - Terraform module to provision an EKS IAM Role for Service Account | ||
| - [terraform-aws-eks-spotinst-ocean-nodepool](https://github.com/cloudposse/terraform-aws-eks-spotinst-ocean-nodepool) - A terraform module to create an EKS node pool with Spot Ocean by Spot.io |
osterman
reviewed
Jan 26, 2021
README.yaml
Outdated
| description: A terraform module to create an EKS node pool with Spot Ocean by Spot.io | ||
| url: https://github.com/cloudposse/terraform-aws-eks-spotinst-ocean-nodepool | ||
| - name: terraform-provider-aws | ||
| description: terraform-provider-aws |
There was a problem hiding this comment.
Also, can you use the description from github?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
references
closes #123, if this PR closes a GitHub issue#123