Update Terraform cloudposse/iam-system-user/aws module initialization…

[andrelohmann]

… - added iam_access_key_max_age parameter

what

• iam_access_key_max_age was added to the variables.tf file as a copy from cloudposse/iam-system-user/aws module
• iam_access_key_max_age is handed over as a parameter in cloudposse/iam-system-user/aws module instatiation

why

• iam_access_key_max_age defaults to 30 days now
• every time the inheriting modules (e.g. terraform-aws-s3-bucket) are updated, this leads to a recreation of the s3 user as with an expired Access Key

[Nuru]

Thank you for your contribution.

Unfortunately, we are removing this feature due to the confusion to the community of our terraform users that has been caused by requiring the cloudposse/awsutils Terraform provider to provide the feature. The error messages stemming from the missing provider block configuration are causing more of a support headache than it is worth. Since we implemented this feature, most CI/CD providers have implemented a better way to obtain short-lived CI/CD credentials (e.g. GitHub Actions and CircleCI both support OIDC with AWS, GCP, Azure, etc).

[andrelohmann]

@Nuru sorry to ask again, I don't really get your comment.
What kind of feature are you talking about, that will be deprecated? The cloudposse/awsutils (and therefor the "context")? Or will the "iam_access_key_max_age" being deprecated, so that the generated AK/SK are no longer expiring?

[Nuru]

What kind of feature are you talking about, that will be deprecated? The cloudposse/awsutils (and therefor the "context")? Or will the "iam_access_key_max_age" being deprecated, so that the generated AK/SK are no longer expiring?

@andrelohmann Both. See the v1.0.0 Release Notes