Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom policy to lambda role #8

Merged
merged 8 commits into from
Apr 15, 2022
Merged

Add custom policy to lambda role #8

merged 8 commits into from
Apr 15, 2022

Conversation

jamengual
Copy link
Contributor

what

  • Add user provides policy to be attached to lambda role

why

  • Custom policies are needed for lambda to use resources like KMS, Secrets and others.

@jamengual jamengual requested review from a team as code owners April 14, 2022 03:27
@jamengual
Copy link
Contributor Author

/test all

nitrocode
nitrocode reviewed Apr 14, 2022
View reviewed changes
iam-role.tf Outdated Show resolved Hide resolved
@jamengual
Copy link
Contributor Author

/test all

nitrocode
nitrocode reviewed Apr 14, 2022
View reviewed changes
iam-role.tf Outdated Show resolved Hide resolved
nitrocode
nitrocode reviewed Apr 14, 2022
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
nitrocode
nitrocode requested changes Apr 14, 2022
View reviewed changes
Copy link
Member

@nitrocode nitrocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments

jamengual and others added 2 commits April 14, 2022 16:24
@jamengual @nitrocode
Update iam-role.tf
b3a3ea2 
Co-authored-by: nitrocode <[email protected]>
@jamengual @nitrocode
Update variables.tf
c77894e 
Co-authored-by: nitrocode <[email protected]>
@jamengual
Copy link
Contributor Author

/test all

@jamengual
Copy link
Contributor Author

/test all

aknysh
aknysh reviewed Apr 15, 2022
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
aknysh
aknysh previously approved these changes Apr 15, 2022
View reviewed changes
@aknysh
Copy link
Member

aknysh commented Apr 15, 2022

@jamengual approved with one nitpick

nitrocode
nitrocode previously approved these changes Apr 15, 2022
View reviewed changes
@nitrocode @aknysh
Update variables.tf
952b1b2 
Co-authored-by: Andriy Knysh <[email protected]>
@nitrocode nitrocode dismissed stale reviews from aknysh and themself via 952b1b2 April 15, 2022 00:14
nitrocode
nitrocode previously approved these changes Apr 15, 2022
View reviewed changes
@jamengual
Copy link
Contributor Author

/test all

@jamengual jamengual merged commit 6692de7 into main Apr 15, 2022
@jamengual jamengual deleted the add_custom_policy branch April 15, 2022 02:52
@rstml rstml mentioned this pull request Apr 21, 2022
Closed
@nitrocode nitrocode mentioned this pull request Apr 21, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

@aknysh aknysh aknysh left review comments

@max-lobur max-lobur Awaiting requested review from max-lobur max-lobur is a code owner automatically assigned from cloudposse/contributors

@Benbentwo Benbentwo Awaiting requested review from Benbentwo Benbentwo is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamengual @aknysh @nitrocode