Adds private_zone option to data lookup #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/codefresh run test |
aknysh
reviewed
Jan 25, 2020
There was a problem hiding this comment.
thanks @joshmyers
please rebuild README
make init
make readme/deps
make readme
This maintains current behaviour by defaulting to false.
joshmyers
force-pushed
the
support_private_zone_lookups
branch
from
fad51bd to
a6b7263
Compare
|
@aknysh Had run |
|
/codefresh run test |
exequielrafaela
added a commit
to binbashar/terraform-aws-route53-alias
that referenced
this pull request
Jan 27, 2020
Adds private_zone option to data lookup (cloudposse#19)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Adds private_zone option to data lookup. This maintains current behaviour by defaulting to false.
why
Because sometimes we want to lookup a private hosted zone.