use minimum versions for provider pinning

[woz5999]

what

set minimum versions for providers without pinning to a specific major version

why

the current method makes it very difficult to maintain or upgrade consistent provider versions within a project

references

https://www.terraform.io/docs/configuration/provider-requirements.html#best-practices-for-provider-versions

[scream314]

Hey @woz5999 !

Thank you for your PR. I think I have the same issue as you do. My problem is with your PR that it would introduce the same problem but in reverse. In case of breaking changes in v4, you might need to pin the version back...

[woz5999]

@scream314 This scenario is anticipated and covered by the official best practice recommended by HashiCorp in the link in the description.

Do not use ~> (or other maximum-version constraints) for modules you intend to reuse across many configurations, even if you know the module isn't compatible with certain newer versions. Doing so can sometimes prevent errors, but more often it forces users of the module to update many modules simultaneously when performing routine upgrades. Specify a minimum version, document any known incompatibilities, and let the root module manage the maximum version.

https://www.terraform.io/docs/configuration/provider-requirements.html#best-practices-for-provider-versions

[woz5999]

@aknysh

[woz5999]

@osterman

[osterman]

/test all

[Nuru]

/test all

[osterman]

Thanks @woz5999 for linking to that official best practice! We've learned this lesson the hard way. Will incorporate this into our own best practices.