Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README does not match actual default value #123

Closed
mburns opened this issue Dec 23, 2021 · 1 comment
Closed

README does not match actual default value #123

mburns opened this issue Dec 23, 2021 · 1 comment
Labels
bug 🐛 An issue with the system

Comments

@mburns
Copy link

mburns commented Dec 23, 2021

Describe the Bug

abort_incomplete_multipart_upload_days defaults to 90, but is documented as defaulting to 5. This change landed in #85

Expected Behavior

README should list default value of abort_incomplete_multipart_upload_days as 90

Steps to Reproduce

  1. the actual version definition: https://github.com/cloudposse/terraform-aws-s3-bucket/blob/master/variables.tf#L115
  2. the readme value: https://github.com/cloudposse/terraform-aws-s3-bucket/blob/master/README.md#inputs
  3. note the mismatch

Additional Context

I tried filing this as #122 but was closed by the bot when it reverted my change via 'auto formatting'. Apologies if I've misunderstood the process.
@mburns mburns added the bug 🐛 An issue with the system label Dec 23, 2021
@mburns
Copy link
Author

mburns commented Dec 23, 2021

seems to be a duplicate of #92

@mburns mburns closed this as completed Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 An issue with the system
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mburns