Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multiple lifecycle rules #85

Merged
merged 15 commits into from
Apr 9, 2021
Merged

Add support for multiple lifecycle rules #85

merged 15 commits into from
Apr 9, 2021

Conversation

maeghan-porter
Copy link
Contributor

what

  • Add the ability to set multiple lifecycle rules on the bucket.

why

  • There are cases where multiple lifecycle rules are desired, which can be made different by tag and/or prefix.

@maeghan-porter maeghan-porter requested review from a team as code owners April 8, 2021 19:26
@mergify
Copy link

mergify bot commented Apr 8, 2021

This pull request is now in conflict. Could you fix it @maeghan-porter? 🙏

bridgecrew[bot]
bridgecrew bot reviewed Apr 8, 2021
View reviewed changes
Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bridgecrew has found 2 infrastructure configuration errors in this PR ⬇️

main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
jamengual
jamengual reviewed Apr 8, 2021
View reviewed changes
variables.tf Show resolved Hide resolved
@maeghan-porter maeghan-porter requested a review from a team as a code owner April 8, 2021 19:47
@jamengual
Copy link
Contributor

/test all

@jamengual
Copy link
Contributor

/test all

@jamengual
Copy link
Contributor

/test all

@jamengual
Copy link
Contributor

/test all

1 similar comment
@jamengual
Copy link
Contributor

/test all

jamengual
jamengual previously approved these changes Apr 8, 2021
View reviewed changes
@jamengual
Copy link
Contributor

/test all

@jamengual
Copy link
Contributor

/test all

jamengual
jamengual previously approved these changes Apr 9, 2021
View reviewed changes
@mergify mergify bot dismissed jamengual’s stale review April 9, 2021 17:21

This Pull Request has been updated, so we're dismissing all reviews.

@jamengual
Copy link
Contributor

/test all

@jamengual jamengual merged commit d8ebed8 into cloudposse:master Apr 9, 2021
adamantike added a commit to adamantike/terraform-aws-s3-bucket that referenced this pull request Jun 15, 2021
@adamantike
Remove unused variable abort_incomplete_multipart_upload_days
d73a84e 
The `abort_incomplete_multipart_upload_days` variable isn't being used
since the introduction of `lifecycle_rules` in
cloudposse#85.
@adamantike adamantike mentioned this pull request Jun 15, 2021
Merged
This was referenced Dec 23, 2021
Closed
Closed
@korenyoni korenyoni mentioned this pull request Jan 16, 2022
Closed
@renovate renovate bot mentioned this pull request Mar 7, 2022
Closed
1 task
@renovate renovate bot mentioned this pull request Apr 24, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridgecrew bridgecrew[bot] bridgecrew[bot] left review comments

@jamengual jamengual jamengual approved these changes

@osterman osterman osterman approved these changes

@dotCipher dotCipher Awaiting requested review from dotCipher

@nitrocode nitrocode Awaiting requested review from nitrocode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maeghan-porter @jamengual @osterman @cloudpossebot