Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of S3 bucket event notification resource and Addition of S3 directory optional resource #239

Closed
mayank0202 opened this issue Aug 6, 2024 · 0 comments

Comments

@mayank0202
Copy link
Contributor

Describe the Feature

This feature will make s3 event notifications which will have 3 options to trigger lambda or queue or topic so we can define a resource from this documentation
aws_s3_bucket_notification
Here is the docs link - https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket_notification

we can also add s3 directory bucket which is a new feature in aws so addition of optional resource can be done if someone needs to use that with the help of terraform
aws_s3_directory_bucket
Here is the docs link - https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_directory_bucket

Expected Behavior

It should create event notifications based on the input variable
event_notification_details.enabled if its marked as true then only a end user can define whether to use lambda , sqs or sns as a trigger for event notifications else by default it should be marked as false

s3_directory_bucket will use the S3 Express One Zone storage class, which is recommended if your application is performance sensitive and benefits from single-digit millisecond PUT and GET latencies.

A directory bucket name consists of a base name that you provide, and a suffix that contains the ID of the AWS Availability Zone that your bucket is located in and --x-s3.

so again this resource should be optional and a bucket_name for this will be a combined name then only this resource will work and by default this should be marked as false
For more information refer to docs

https://docs.aws.amazon.com/AmazonS3/latest/userguide/directory-buckets-overview.html

Use Case

My use case is just to have s3 event notifications with sns topic and that feature is required from cloudposse and i have done a contribution in the PR as well

Describe Ideal Solution

It should create event notifications based on the input variable
event_notification_details.enabled if its marked as true then only a end user can define whether to use lambda , sqs or sns as a trigger for event notifications else by default it should be marked as false

s3_directory_bucket will use the S3 Express One Zone storage class, which is recommended if your application is performance sensitive and benefits from single-digit millisecond PUT and GET latencies.

A directory bucket name consists of a base name that you provide, and a suffix that contains the ID of the AWS Availability Zone that your bucket is located in and --x-s3.

so again this resource should be optional and a bucket_name for this will be a combined name then only this resource will work and by default this should be marked as false
For more information refer to docs

https://docs.aws.amazon.com/AmazonS3/latest/userguide/directory-buckets-overview.html

Alternatives Considered

No response

Additional Context

No response

aknysh added a commit to mayank0202/terraform-aws-s3-bucket-1 that referenced this issue Aug 8, 2024
nitrocode added a commit to mayank0202/terraform-aws-s3-bucket-1 that referenced this issue Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant