Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix privileged_principal_arns not creating bucket policy #101

Merged
merged 2 commits into from Aug 11, 2021
Merged

fix privileged_principal_arns not creating bucket policy #101

merged 2 commits into from Aug 11, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 10, 2021

what

  • The privileged_principal_arns option is not creating a bucket policy.

why

  • A check at the s3_bucket_policy is missing

references

@ghost ghost requested review from a team as code owners August 10, 2021 14:49
@ghost ghost requested review from bradj and joe-niland August 10, 2021 14:49
@nitrocode
Copy link
Member

/test all

@nitrocode nitrocode merged commit 12ac1d8 into cloudposse:master Aug 11, 2021
@ghost ghost deleted the fix/privileged_principal_arns-creat-bucket-policy branch August 11, 2021 08:58
@nitrocode nitrocode mentioned this pull request Aug 16, 2021
Closed
@nitrocode nitrocode mentioned this pull request Aug 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradj bradj Awaiting requested review from bradj

@joe-niland joe-niland Awaiting requested review from joe-niland

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nitrocode @cloudpossebot