Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable bucket key for reducing the cost of SSE-KMS with Amazon S3 #115

Merged
merged 7 commits into from
Jan 16, 2022

Conversation

bkmnaidu
Copy link
Contributor

@bkmnaidu bkmnaidu commented Nov 3, 2021

Signed-off-by: Krishna Mohan Bandi [email protected]

what

  • Allow S3 bucket key to be enabled to reduce the cost of SSE-KMS usage with Amazon S3

why

  • When KMS encryption is enabled for an Amazon S3 bucket, there is a limit on the number of KMS API calls that can be made. Enabling bucket key not only allows to reduce the number of KMS API calls but also reduces the cost of SSE-KMS with Amazon S3.

references

@bkmnaidu bkmnaidu requested review from a team as code owners November 3, 2021 12:46
@bkmnaidu bkmnaidu requested review from Gowiem and SweetOps November 3, 2021 12:46
@nitrocode
Copy link
Member

/test all

nitrocode
nitrocode previously approved these changes Nov 4, 2021
@korenyoni korenyoni added the no-release Do not create a new release (wait for additional code changes) label Jan 16, 2022
@mergify mergify bot dismissed nitrocode’s stale review January 16, 2022 18:50

This Pull Request has been updated, so we're dismissing all reviews.

@korenyoni korenyoni added the enhancement New feature or request label Jan 16, 2022
@korenyoni
Copy link
Member

korenyoni commented Jan 16, 2022

I've taken the liberty to update the variable descriptions — there was some unintended repetition and also I just cleaned it up a bit.

Also, looks like you forgot to update examples/complete/main.tf and add the bucket_key_enabled variable in the module invocation. I've taken the liberty to fix this myself — along my feedback on the new variable being put into the wrong tfvars fixture.

…tf; move bucket_key_enabled variable to main variable fixture.
…aform-aws-s3-bucket into optional-bucket-key-enable
@korenyoni
Copy link
Member

/test all

@korenyoni korenyoni merged commit e9dcc21 into cloudposse:master Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request no-release Do not create a new release (wait for additional code changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support bucket keys
4 participants