Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed deprecated argument object_lock_enabled in aws_s3_bucket #144

Closed
wants to merge 2 commits into from
Closed

Removed deprecated argument object_lock_enabled in aws_s3_bucket #144

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10cd747
Removed deprecated argument. object_lock_enabled is enabled for this …
Apr 14, 2022
7d47803
updated git config to resolve auto-format/preivilleged checout.
Apr 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,7 @@ resource "aws_s3_bucket" "default" {
count = local.enabled ? 1 : 0
bucket = local.bucket_name
force_destroy = var.force_destroy

dynamic "object_lock_configuration" {
for_each = var.object_lock_configuration != null ? [1] : []

content {
object_lock_enabled = "Enabled"
}
}


Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOW   Ensure S3 Bucket has public access blocks
    Resource: aws_s3_bucket.default | ID: BC_AWS_NETWORKING_52

How to Fix

resource "aws_s3_bucket" "bucket_good_1" {
  bucket = "bucket_good"
}

resource "aws_s3_bucket_public_access_block" "access_good_1" {
  bucket = aws_s3_bucket.bucket_good_1.id

  block_public_acls   = true
  block_public_policy = true
}

Description

When you create an S3 bucket, it is good practice to set the additional resource **aws_s3_bucket_public_access_block** to ensure the bucket is never accidentally public.

We recommend you ensure S3 bucket has public access blocks. If the public access block is not attached it defaults to False.

Dependent Resources



Calculating...

tags = module.this.tags
imran-init marked this conversation as resolved.
Show resolved Hide resolved
}

Expand Down