Bugfix #147
Merged
Bugfix #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nuru
added
the
no-release
|
/test all |
aknysh
reviewed
Apr 20, 2022
| object_size_less_than = and.value.object_size_less_than | ||
| prefix = and.value.prefix | ||
| tags = and.value.tags | ||
| dynamic "filter" { |
There was a problem hiding this comment.
why do we need this empty filter?
There was a problem hiding this comment.
if we need it, maybe add a comment why (not easy to understand by looking at the code)
There was a problem hiding this comment.
if we need it, maybe add a comment why (not easy to understand by looking at the code)
Did you read line 168 (the line above this one)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what && why
lifecycle_configuration_ruleswith expires and without #137source_policy_documentsinput, fixes source_policy_documents ignored in certain cases #145notes
This will become version 2.0