-
-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix website support, remove awsutils depenencies #158
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nuru
requested review from
woz5999,
RothAndrew,
aknysh,
Gowiem,
mcalhoun,
milldr,
nitrocode and
osterman
September 5, 2022 00:46
/test all |
aknysh
reviewed
Sep 7, 2022
aknysh
reviewed
Sep 7, 2022
aknysh
reviewed
Sep 7, 2022
aknysh
reviewed
Sep 7, 2022
aknysh
reviewed
Sep 7, 2022
aknysh
reviewed
Sep 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please see comments
/test all |
/test all |
aknysh
approved these changes
Sep 7, 2022
Cool! Thank you! |
argh, wrong user. Thanks! :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes
This release has what can be considered breaking changes, but mostly because it either reverts breaking changes introduced in v2.0.2 or fixes features that were previously broken and unusable.
website_inputs
input is replaced bywebsite_configuration
andwebsite_redirect_all_requests_to
. Thecors_rule_inputs
input is replaced bycors_configuration
. Thanks to @jurgen-weber-deltatre for helping with this.New Features
cloudposse/awsutils
Terraform provider with the AWS region and been reverted. This module no longer uses that provider.website_configuration
andcors_configuration
, or withwebsite_redirect_all_requests_to
. The website endpoint and base domain are now available as outputs.store_access_key_in_ssm
. When stored in SSM, the secret key is not output by this module as a Terraform output, preventing it from being stored unencrypted in the Terraform state file.access_key_enabled = false
. You can also use this feature to rotate an access key by setting it tofalse
and applying to delete the key, then setting it totrue
and applying to create a new one.Note that in general we now recommend against creating an IAM user, and recommend using AWS OIDC to create an authentication path for users and systems that do not have native IAM credentials. Also note that you can assign permissions to existing AWS users and roles via
grants
orprivileged_principal_arns
.what && why
terraform-aws-s3-user
to v1.0.0 and add inputsaccess_key_enabled
,store_access_key_in_ssm
, andssm_base_path
in order tocloudposse/awsutils
Terraform provider. Seeterraform-aws-iam-system-user
v1.0.0 Release Notes for further details and justification.website_inputs
(which never worked) withwebsite_configuration
andwebsite_redirect_all_requests_to
. See dynamically create website inputs with the new provider and its colli… #142 for further details and justification.cors_rule_inputs
withcors_configuration
to match resource name.references