Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to specify cors-rules #16

Merged
merged 3 commits into from
May 20, 2020
Merged

Add the ability to specify cors-rules #16

merged 3 commits into from
May 20, 2020

Conversation

jjungnickel
Copy link
Contributor

@aknysh
Copy link
Member

aknysh commented Aug 19, 2019

/codefresh run test

@goruha
Copy link
Member

goruha commented Jan 7, 2020

@jjungnickel could you resolve conflicts?

goruha
goruha previously requested changes Jan 7, 2020
View reviewed changes
variables.tf
@@ -98,3 +98,14 @@ variable "allow_encrypted_uploads_only" {
default = false
description = "Set to `true` to prevent uploads of unencrypted objects to S3 bucket"
}

variable "cors_rule_inputs" {
type = list(object({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description required

@goruha
Copy link
Member

goruha commented Jan 7, 2020

@jjungnickel

Also please rebuild README by executing these commands:

make init
make readme/deps
make readme

It will add the new variables and outputs to README.md automatically.

In general, any changes to README should be made in README.yaml (not in this case), and after that executing the commands above will rebuild README.yaml into README.md and add all new variables and outputs to README.md

thanks

@aknysh
Copy link
Member

aknysh commented Jan 14, 2020

@jjungnickel can you rebase and address the comments?

@jjungnickel
Copy link
Contributor Author

@aknysh Sorry for the long delay. I rebased and added the description, rebuilding readme

@m0xx
Copy link

m0xx commented May 7, 2020

Just to know, will this get merge? Thanks

@maximmi
Copy link
Contributor

maximmi commented May 19, 2020

/codefresh run test

maximmi
maximmi approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@maximmi maximmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @jjungnickel

@maximmi maximmi dismissed goruha’s stale review May 20, 2020 07:56

comments were addressed

@maximmi maximmi merged commit 8aea781 into cloudposse:master May 20, 2020
@maximmi
Copy link
Contributor

maximmi commented May 20, 2020

@jjungnickel @m0xx here is new release: https://github.com/cloudposse/terraform-aws-s3-bucket/releases/tag/0.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximmi maximmi maximmi approved these changes

@goruha goruha goruha left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jjungnickel @aknysh @goruha @m0xx @maximmi