Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always include aws_s3_bucket_versioning resource #172

Merged
merged 3 commits into from
May 5, 2023

Conversation

mviamari
Copy link
Contributor

@mviamari mviamari commented Apr 5, 2023

what

  • Always create an aws_s3_bucket_versioning resource to track changes made to bucket versioning configuration

why

  • When there is no aws_s3_bucket_versioning, the expectation is that the bucket versioning is disabled/suspend for the bucket. If bucket versioning is turned on outside of terraform (e.g. through the console), the change is not detected by terraform unless the aws_s3_bucket_versioning resource exists.

references

@mviamari mviamari requested review from a team as code owners April 5, 2023 17:28
@mviamari mviamari requested review from jamengual and joe-niland April 5, 2023 17:28
@mviamari mviamari requested a review from a team as a code owner April 26, 2023 21:31
@Nuru Nuru added the no-release Do not create a new release (wait for additional code changes) label May 5, 2023
@Nuru Nuru merged commit 148011d into cloudposse:master May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-release Do not create a new release (wait for additional code changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes to Bucket Versioning Configuration outside of terraform not detected.
3 participants