adding dynamics to allow for other expiration types #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/codefresh run test |
|
$codefresh does not like me |
|
/codefresh run test |
|
mmm I do not have access to see what exactly failed can you @maximmi ? |
|
/codefresh run test |
nevermind I found it and pushed the fix |
|
/codefresh run test |
|
@maximmi I do not see a new tagged version, does it take some time to show up ? |
now is showing up, awesome, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a copy from : https://github.com/cloudposse/terraform-aws-s3-log-storage/blob/master/main.tf
to enable additional options for the s3 lifecycle expirations
adding support for abort_incomplete_multipart_upload_days