Disable retention option

[jamengual]

Allow to disabling any retantion option

[aknysh]

@jamengual please see comments

[aknysh]

@jamengual please see comments

[jamengual]

@jamengual please see comments

I committed your suggestions

[aknysh]

@jamengual
I think you wanted to be able to enable two types of transitions (standard and glacier) at the same time, as shown in https://www.terraform.io/docs/providers/aws/r/s3_bucket.html#using-object-lifecycle

For this, you need to add two dynamic "transition" blocks, each with its own enable flag, and each using the hardcoded storage_class (STANDARD_IA or GLACIER) and each using its own days variable (glacier_transition_days and standard_transition_days.

In this case, the module will support both (optional) transitions (not only one of those at a time)

Please update.

Thanks

[jamengual]

@jamengual
I think you wanted to be able to enable two types of transitions (standard and glacier) at the same time, as shown in https://www.terraform.io/docs/providers/aws/r/s3_bucket.html#using-object-lifecycle

For this, you need to add two dynamic "transition" blocks, each with its own enable flag, and each using the hardcoded storage_class (STANDARD_IA or GLACIER) and each using its own days variable (glacier_transition_days and standard_transition_days.

In this case, the module will support both (optional) transitions (not only one of those at a time)

Please update.

Thanks

I added the double dynamic, I was simplifying too much

[aknysh]

/codefresh run test

[aknysh]

thanks @jamengual