Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: s3 lambda event notification assignments #253

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

mpajuelofernandez
Copy link
Contributor

@mpajuelofernandez mpajuelofernandez commented Sep 18, 2024

what

It seems there is a typo kind if error here

dynamic "lambda_function" {
    for_each = var.event_notification_details.lambda_list
    content {
      lambda_function_arn = lambda_function.value.arn
      events              = lambda.value.events
      filter_prefix       = lambda_function.value.filter_prefix
      filter_suffix       = lambda_function.value.filter_suffix
    }
  }

I think it should be

dynamic "lambda_function" {
    for_each = var.event_notification_details.lambda_list
    content {
      lambda_function_arn = lambda_function.value.arn
      events              = lambda_function.value.events
      filter_prefix       = lambda_function.value.filter_prefix
      filter_suffix       = lambda_function.value.filter_suffix
    }
  }

why

The S3 notification can not be created unless this is fixed

references

This should fix #252

@mpajuelofernandez mpajuelofernandez requested review from a team as code owners September 18, 2024 10:25
@mergify mergify bot added the triage Needs triage label Sep 18, 2024
Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid find 👍

@Gowiem Gowiem added patch A minor, backward compatible change bugfix Change that restores intended behavior labels Sep 24, 2024
@Gowiem
Copy link
Member

Gowiem commented Sep 24, 2024

/terratest

@mergify mergify bot removed the triage Needs triage label Sep 24, 2024
@Gowiem Gowiem enabled auto-merge (squash) September 24, 2024 14:58
@Gowiem Gowiem disabled auto-merge September 24, 2024 14:58
@Gowiem Gowiem changed the title Fix for s3 lambda notification fix: s3 lambda event notification assignments Sep 24, 2024
@Gowiem Gowiem enabled auto-merge (squash) September 24, 2024 14:59
@Gowiem Gowiem merged commit a316dfb into cloudposse:main Sep 24, 2024
35 of 44 checks passed
Copy link

These changes were released in v4.7.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Change that restores intended behavior patch A minor, backward compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lamda value has not been declared in event_notification_details
2 participants