Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use github status updater #38

Merged
merged 12 commits into from
Jun 10, 2020
Merged

use github status updater #38

merged 12 commits into from
Jun 10, 2020

Conversation

osterman
Copy link
Member

@osterman osterman commented Jun 8, 2020 •
edited
Loading

what

  • dispatch to cloudposse/actions
  • use cloudposse/github-status-updater to set status of dispatch events

why

  • dispatch events are always triggered against master, so the the status for PR is not updated
  • use cloudposse/actions so we can be more dry

@osterman osterman requested a review from a team as a code owner June 8, 2020 00:47
aknysh
aknysh reviewed Jun 8, 2020
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Jun 8, 2020
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Jun 8, 2020
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Jun 8, 2020
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@osterman
Copy link
Member Author

/test ping

@osterman osterman requested a review from aknysh June 10, 2020 00:58
@osterman osterman merged commit f5b2162 into master Jun 10, 2020
@osterman osterman deleted the use-status-updater branch June 10, 2020 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh Awaiting requested review from aknysh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@osterman @aknysh