Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix s3 user tagging #39

Merged
merged 4 commits into from
Jul 30, 2020
Merged

Fix s3 user tagging #39

merged 4 commits into from
Jul 30, 2020

Conversation

nitrocode
Copy link
Member

what

  • Fixes s3 user tagging by upgrading the module reference

why

  • To fix s3 user tagging

references

@nitrocode nitrocode requested review from osterman and aknysh June 16, 2020 21:53
@nitrocode
Copy link
Member Author

@osterman is this another case where we can ignore the failing codefresh test/readme ?

@osterman
Copy link
Member

/test all

@osterman
Copy link
Member

/rebuild-readme

@nitrocode
Copy link
Member Author

/test all

@nitrocode
Copy link
Member Author

/test all

@osterman
Copy link
Member

image

@nitrocode
Copy link
Member Author

@osterman this PR depends on this PR cloudposse/terraform-aws-iam-s3-user#14

@nitrocode
Copy link
Member Author

/test all

@nitrocode
Copy link
Member Author

/rebuild-readme

@nitrocode
Copy link
Member Author

/test test/readme

@nitrocode
Copy link
Member Author

/test all

@nitrocode nitrocode merged commit 247b287 into master Jul 30, 2020
@nitrocode nitrocode deleted the fix-s3-user-tagging branch July 30, 2020 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

@aknysh aknysh Awaiting requested review from aknysh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User created without tags
3 participants
@nitrocode @osterman @actions-bot