Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support S3 Grants #40

Merged
merged 13 commits into from
Jul 29, 2020
Merged

Support S3 Grants #40

merged 13 commits into from
Jul 29, 2020

Conversation

johncblandii
Copy link
Contributor

what

  • Support S3 grants

why

  • S3 buckets support canned ACL strings or custom grants. Grants are needed to enable external access to other accounts and users.

references

@johncblandii johncblandii added the enhancement New feature or request label Jul 28, 2020
@johncblandii
Copy link
Contributor Author

/rebuild-readme

@johncblandii
Copy link
Contributor Author

/terraform-fmt

@johncblandii
Copy link
Contributor Author

/test

@johncblandii
Copy link
Contributor Author

/test readme

@johncblandii
Copy link
Contributor Author

/test bats

@johncblandii
Copy link
Contributor Author

/test terratest

1 similar comment
@johncblandii
Copy link
Contributor Author

/test terratest

@johncblandii
Copy link
Contributor Author

/test terratest

@johncblandii
Copy link
Contributor Author

/test terratest

@johncblandii
Copy link
Contributor Author

/test terratest

@johncblandii
Copy link
Contributor Author

/test terratest

@johncblandii
Copy link
Contributor Author

/test terratest

@johncblandii
Copy link
Contributor Author

/test terratest

@johncblandii
Copy link
Contributor Author

This is ready for a final review, but the tests are failing since I created the resources locally and eventual consistency hasn't been reached across regions.

TestExamplesComplete 2020-07-29T08:02:23Z logger.go:66: Error: Error creating S3 bucket: Error creating S3 bucket eg-test-s3-test, retrying: OperationAborted: A conflicting conditional operation is currently in progress against this resource. Please try again.

osterman
osterman previously approved these changes Jul 29, 2020
View reviewed changes
@johncblandii
Copy link
Contributor Author

/test terratest

@johncblandii
Copy link
Contributor Author

/test bats

@johncblandii
Copy link
Contributor Author

/test readme

@johncblandii
Copy link
Contributor Author

/test terratest

@johncblandii
Copy link
Contributor Author

/test bats

@johncblandii
Copy link
Contributor Author

/test readme

@johncblandii
Copy link
Contributor Author

/test readme

@johncblandii
Copy link
Contributor Author

/test terratest

@johncblandii
Copy link
Contributor Author

/test bats

@johncblandii
Copy link
Contributor Author

/test terratest

@johncblandii
Copy link
Contributor Author

/test bats

@johncblandii
Copy link
Contributor Author

/test readme

@johncblandii johncblandii merged commit 3a7bfc5 into master Jul 29, 2020
@johncblandii johncblandii deleted the feature/s3-grants branch July 29, 2020 19:57
Nuru added a commit that referenced this pull request May 11, 2023
@Nuru
Remove reference to TF_DATA_DIR retained by mistake in #40
ed4e161
@Nuru Nuru mentioned this pull request May 11, 2023
Merged
Nuru added a commit that referenced this pull request May 15, 2023
@Nuru
Remove reference to TF_DATA_DIR retained by mistake in #40 (#181)
a8d63f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johncblandii @osterman