Policy to allow only ssl uploads #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jaymed thanks for the PR, please rebase |
* Added policy to allow only ssl/https uploads * Merge user defined bucket policy with any additional/enabled policies defined within the module. This prevents overriding the user defined policy (`var.policy`) as long as the `sid` values are distinct. Closes cloudposse#11
* Allow merging the user defined policy by specifying it in the `source_json` of the default `aws_s3_bucket` resource. This simplifies the previous commit which created a new resource. * Remove the s3 bucket resource `policy` argument to avoid colliding with the merged s3 bucket policy document that will define the overall bucket policy.
Thanks! I just rebased. Please take a look. |
|
This pull request is now in conflict. Could you fix it @jaymed? 🙏 |
jamengual
pushed a commit
that referenced
this pull request
Apr 4, 2021
* Merge user defined policy with ssl policy * Allow merging the user defined policy by specifying it in the `source_json` of the default `aws_s3_bucket` resource. This simplifies the previous commit which created a new resource. * Remove the s3 bucket resource `policy` argument to avoid colliding with the merged s3 bucket policy document that will define the overall bucket policy. Conflicts: main.tf * use module.this.enabled * Auto Format * Update main.tf Co-authored-by: Jay Medrano <[email protected]> Co-authored-by: cloudpossebot <[email protected]>
|
This is already addressed in the new versions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
policyvariable and the other encryption policy. This prevents overriding the user defined policy (mentioned in issue allow_encrypted_uploads_only overrides policy #11) as long as thesidvalues are distinct.why
references