Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

policy to allow only encrypted uploads #5

Merged
merged 6 commits into from
Feb 27, 2019
Merged

policy to allow only encrypted uploads #5

merged 6 commits into from
Feb 27, 2019

Conversation

maximmi
Copy link
Contributor

@maximmi maximmi commented Feb 26, 2019 •
edited
Loading

what

  • policy to allow only encrypted uploads

why

  • using S3 as chamber backend highly recommend to use such policy

aknysh
aknysh reviewed Feb 26, 2019
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Feb 26, 2019
View reviewed changes
main.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Feb 26, 2019
View reviewed changes
main.tf Outdated Show resolved Hide resolved
aknysh
aknysh previously requested changes Feb 26, 2019
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

aknysh
aknysh reviewed Feb 26, 2019
View reviewed changes
main.tf Outdated Show resolved Hide resolved
@goruha goruha dismissed aknysh’s stale review February 27, 2019 10:25

Comments addressed

@goruha goruha merged commit 0d0a773 into master Feb 27, 2019
@goruha goruha deleted the encrypted-uploads-only branch February 27, 2019 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh left review comments

@goruha goruha goruha approved these changes

@osterman osterman Awaiting requested review from osterman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maximmi @goruha @aknysh