Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for s3 bucket replication configuration #56

Merged
merged 15 commits into from
Oct 27, 2020
Merged

Adding support for s3 bucket replication configuration #56

merged 15 commits into from
Oct 27, 2020

Conversation

danjbh
Copy link
Contributor

@danjbh danjbh commented Oct 15, 2020 •
edited
Loading

what

  • Adding support for custom replication_configuration definition
  • Adding master flag to enable/disable s3 bucket replication
  • Adding input variable for ARN of destination bucket
  • Creates all required IAM roles/policies

NOTE: The destination bucket must already exist!

why

  • Allows the user to enable s3 bucket replication and define custom rules, filters, etc!

danjbh
danjbh commented Oct 15, 2020
View reviewed changes
variables.tf Show resolved Hide resolved
@danjbh danjbh marked this pull request as ready for review October 19, 2020 17:11
@danjbh danjbh requested a review from a team as a code owner October 19, 2020 17:11
@danjbh danjbh requested review from htplbc, nitrocode and aknysh October 19, 2020 17:11
aknysh
aknysh reviewed Oct 19, 2020
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
@danjbh
Copy link
Contributor Author

danjbh commented Oct 26, 2020

/test all

aknysh
aknysh reviewed Oct 27, 2020
View reviewed changes
main.tf Show resolved Hide resolved
aknysh
aknysh reviewed Oct 27, 2020
View reviewed changes
replication.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Oct 27, 2020
View reviewed changes
replication.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Oct 27, 2020
View reviewed changes
replication.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Oct 27, 2020
View reviewed changes
replication.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Oct 27, 2020
View reviewed changes
replication.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Oct 27, 2020
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few comments

@danjbh
Copy link
Contributor Author

danjbh commented Oct 27, 2020

/test all

@danjbh danjbh requested a review from aknysh October 27, 2020 16:17
@danjbh danjbh merged commit 128d9f0 into master Oct 27, 2020
@danjbh danjbh deleted the add-bucket-replication-support branch October 27, 2020 16:26
@joe-niland joe-niland mentioned this pull request Dec 20, 2020
Closed
@alexjurkiewicz alexjurkiewicz mentioned this pull request Jun 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman left review comments

@aknysh aknysh aknysh approved these changes

@htplbc htplbc Awaiting requested review from htplbc

@nitrocode nitrocode Awaiting requested review from nitrocode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danjbh @osterman @aknysh