Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3deeparchive support #78

Merged
merged 7 commits into from
Feb 22, 2021
Merged

S3deeparchive support #78

merged 7 commits into from
Feb 22, 2021

Conversation

bcoddens
Copy link
Contributor

@bcoddens bcoddens commented Feb 22, 2021

Support transition to the deep archive storage class
We need this for our business.

@bcoddens bcoddens requested review from a team as code owners February 22, 2021 08:39
@bcoddens bcoddens requested review from jamengual and 3h4x February 22, 2021 08:39
@maximmi
Copy link
Contributor

maximmi commented Feb 22, 2021

/test all

variables.tf Outdated
variable "enable_glacier_transition" {
type = bool
default = true
default = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bcoddens why to change default behaviour?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct,just tested it.
When you have in variables.tf:

variable "enable_glacier_transition" {
type = bool
default = true
description = "Enables the transition to AWS Glacier which can cause unnecessary costs for huge amount of small files"
}

== The default

variable "enable_deeparchive_transition" {
type = bool
default = false
description = "Enables the transition to AWS Glacier Deep Archive which can cause unnecessary costs for huge amount of small files"
}

And this in your main.tf:

enable_glacier_transition = "false"
enable_deeparchive_transition = "true"

It works fine according to the plan output:

      + noncurrent_version_expiration {
          + days = 90
        }

      + noncurrent_version_transition {
          + days          = 60
          + storage_class = "DEEP_ARCHIVE"
        }

      + transition {
          + days          = 90
          + storage_class = "DEEP_ARCHIVE"
        }
    }

@maximmi
Copy link
Contributor

maximmi commented Feb 22, 2021

/test all

@maximmi maximmi merged commit 90d5dcd into cloudposse:master Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants