Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bucket_name variable #80

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Add bucket_name variable #80

merged 1 commit into from
Mar 25, 2021

Conversation

aknysh
Copy link
Member

@aknysh aknysh commented Mar 25, 2021

what

  • Add bucket_name variable

why

  • Allow users to override the name of the created bucket instead of generating it from the context
  • Useful in situations when a bucket needs to have a name without namespace, environment, name in it

references

In order for the S3 bucket to proxy (not just basic CNAME) through Cloudflare, 
the bucket name has to match the domain.  
That way we can have the bucket completely behind Cloudflare and not exposed to the world, 
provided we added the policy to restrict access from Cloudflare's IP.

@aknysh aknysh self-assigned this Mar 25, 2021
@aknysh aknysh requested review from a team as code owners March 25, 2021 14:54
@aknysh aknysh requested review from jhosteny and 3h4x March 25, 2021 14:54
@aknysh
Copy link
Member Author

aknysh commented Mar 25, 2021

/test all

@aknysh aknysh merged commit 183f4ed into master Mar 25, 2021
@aknysh aknysh deleted the override-bucket-name branch March 25, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants