Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional Object lock configuration added #84

Merged
merged 17 commits into from
Apr 8, 2021
Merged

Optional Object lock configuration added #84

merged 17 commits into from
Apr 8, 2021

Conversation

maximmi
Copy link
Contributor

@maximmi maximmi commented Apr 7, 2021

@maximmi maximmi requested review from osterman, goruha and aknysh April 7, 2021 11:33
@maximmi maximmi requested review from a team as code owners April 7, 2021 11:33
@maximmi
Copy link
Contributor Author

maximmi commented Apr 7, 2021

/rebuild-readme

@maximmi
Copy link
Contributor Author

maximmi commented Apr 7, 2021

/test all

@maximmi
Copy link
Contributor Author

maximmi commented Apr 7, 2021

/test all

@maximmi
Copy link
Contributor Author

maximmi commented Apr 7, 2021

/test all

@maximmi
Copy link
Contributor Author

maximmi commented Apr 7, 2021

/test all

@maximmi
Copy link
Contributor Author

maximmi commented Apr 7, 2021

/test all

@maximmi
Copy link
Contributor Author

maximmi commented Apr 7, 2021

/test all

@maximmi
Copy link
Contributor Author

maximmi commented Apr 7, 2021

/test all

@maximmi
Copy link
Contributor Author

maximmi commented Apr 8, 2021

/test all

@mcalhoun mcalhoun changed the title Optional Object lock configutarion added Optional Object lock configuration added Apr 8, 2021
mcalhoun
mcalhoun previously requested changes Apr 8, 2021
View reviewed changes
Copy link
Member

@mcalhoun mcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just left a few minor suggestions on wording/formatting

README.md Outdated Show resolved Hide resolved
docs/terraform.md Outdated Show resolved Hide resolved
examples/complete/object-lock.us-west-1.tfvars Outdated Show resolved Hide resolved
examples/complete/variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
@mergify mergify bot dismissed mcalhoun’s stale review April 8, 2021 17:38

This Pull Request has been updated, so we're dismissing all reviews.

@maximmi
Copy link
Contributor Author

maximmi commented Apr 8, 2021

/test all

mcalhoun
mcalhoun approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@mcalhoun mcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maximmi maximmi merged commit 35484d3 into master Apr 8, 2021
@maximmi maximmi deleted the object-lock branch April 8, 2021 17:48
@korenyoni korenyoni mentioned this pull request Jan 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcalhoun mcalhoun mcalhoun approved these changes

@osterman osterman Awaiting requested review from osterman

@goruha goruha Awaiting requested review from goruha

@aknysh aknysh Awaiting requested review from aknysh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maximmi @mcalhoun @cloudpossebot