Removing policy attribute for S3 bucket #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing a bug where the bucket policy would flip-flop on Terraform apply if `var.policy` and any of `var.allow_ssl_requests_only`, `var.allow_encrypted_uploads_only` were set.
![bridgecrew[bot]](https://avatars.githubusercontent.com/in/52968?s=60&v=4){kind=small}
| @@ -10,7 +10,6 @@ resource "aws_s3_bucket" "default" { | |||
| bucket = local.bucket_name | |||
| acl = try(length(var.grants), 0) == 0 ? var.acl : null | |||
| force_destroy = var.force_destroy | |||
| policy = var.policy | |||
| tags = module.this.tags | |||
There was a problem hiding this comment.
Error Description: Ensure all data stored in the S3 bucket is securely encrypted at rest
Category: Storage | Severity: HIGH
Resource: aws_s3_bucket [default], lines: 5 - 196
There was a problem hiding this comment.
Isn't this already defined https://github.com/cloudposse/terraform-aws-s3-bucket/blob/master/main.tf#L99 ??
There was a problem hiding this comment.
bridcrew does not understand dynamics with enable variables
There was a problem hiding this comment.
please add : BC_AWS_S3_14 to the bridgecrew comments on the top of the file
There was a problem hiding this comment.
Done! Thanks @jamengual
jamengual
previously approved these changes
Apr 26, 2021
|
/test all |
|
/test all |
1 similar comment
|
/test all |
joe-niland
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
var.policyand any ofvar.allow_ssl_requests_only,var.allow_encrypted_uploads_onlywere setwhy
aws_s3_bucket.policyattribute was competing with theaws_s3_bucket_policyresource