Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally create aws_s3_bucket_public_access_block #94

Merged
merged 6 commits into from
Aug 25, 2021
Merged

Conditionally create aws_s3_bucket_public_access_block #94

merged 6 commits into from
Aug 25, 2021

Conversation

alexjurkiewicz
Copy link
Contributor

It's not needed if none of its options are enabled.

It's not needed if none of its options are enabled.
@alexjurkiewicz alexjurkiewicz requested review from a team as code owners June 28, 2021 04:36
@mergify
Copy link

mergify bot commented Jun 28, 2021

This pull request is now in conflict. Could you fix it @alexjurkiewicz? 🙏

Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bridgecrew has found 0 infrastructure configuration error in this PR ⬇️

@nitrocode
Copy link
Member

/test all

@alexjurkiewicz
Copy link
Contributor Author

I can't see why Bridgecrew check has failed.

main.tf Outdated Show resolved Hide resolved
@alexjurkiewicz
Copy link
Contributor Author

done

@nitrocode nitrocode added the patch A minor, backward compatible change label Aug 25, 2021
nitrocode
nitrocode previously approved these changes Aug 25, 2021
@nitrocode
Copy link
Member

/test all

@mergify mergify bot dismissed nitrocode’s stale review August 25, 2021 12:49

This Pull Request has been updated, so we're dismissing all reviews.

@nitrocode nitrocode merged commit b601290 into cloudposse:master Aug 25, 2021
@nitrocode
Copy link
Member

@alexjurkiewicz thanks for the contribution!

@alexjurkiewicz alexjurkiewicz deleted the only-create-block-when-required branch December 6, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch A minor, backward compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants