Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disambiguate logs #12

Merged
merged 3 commits into from
Sep 28, 2017
Merged

Disambiguate logs #12

merged 3 commits into from
Sep 28, 2017

Conversation

osterman
Copy link
Member

what

  • Add support for attributes property (should have been there anyways)
  • Disambiguate logs by adding logs attribute

why

  • Avoid collisions

@osterman osterman requested a review from aknysh September 28, 2017 21:18
@osterman osterman merged commit e92d02d into master Sep 28, 2017
@osterman osterman deleted the disambiguate-logs branch October 25, 2017 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@osterman @aknysh